Synthetics tidy #1370
Merged
Synthetics tidy #1370
+1,190
−1,274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biscout42
previously approved these changes
Oct 15, 2025
There was a problem hiding this comment.
Thanks a lot for the clean-up. Good catch that Geo data is only private location related, using of existing utils.MapValueFrom and moving api client to a separate file.
I wish we could migrate kibana client to OpenApi / generated one.
One nit question: what is the convention for acceptance test file names? We have internal/kibana/synthetics/parameter/resource_test.go and e.g. internal/kibana/synthetics/monitor/acc_test.go .
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #610
This issue is essentially already done, I've moved some code around to better align with our normal organisation.